Advertisement
Position Modifier not working correctly
Sep 09, 2015 at 05:59
Vues 696
3 Replies
Sep 09, 2015 at 05:59
I've been working on an EA for a while and part of it adjusts the stop loss on positions based on other criteria. The opening conditions allow it to open up to 4 positions at a time, all the buy orders are set with the magic index of 4 and sells are 3.
For some reason the stop loss adjuster is working fine but only on the first position, the other 3 are not being modified at all.
This is probably me with smoke kind of rookie error but if anyone has any ideas that might be able to solve this issue that would be amazing.
Thanks
Tom
For some reason the stop loss adjuster is working fine but only on the first position, the other 3 are not being modified at all.
This is probably me with smoke kind of rookie error but if anyone has any ideas that might be able to solve this issue that would be amazing.
Thanks
Tom
forex_trader_25447
Membre depuis Dec 21, 2010
posts 127
Sep 09, 2015 at 13:33
Is there any Error code ?
Are you sure your value for SL are correct ? It must be :
StopLoss_BUY = OrderOpenPrice() - Distance;
StopLoss_SELL= OrderOpenPrice() + Distance;
Where Order must be Selected before,
and Distance must be greater (>) than
MathMax( MarketInfo(_Symbol,MODE_STOPLEVEL), MarketInfo(_Symbol,MODE_FREEZELEVEL))*_Point;
Are you sure your value for SL are correct ? It must be :
StopLoss_BUY = OrderOpenPrice() - Distance;
StopLoss_SELL= OrderOpenPrice() + Distance;
Where Order must be Selected before,
and Distance must be greater (>) than
MathMax( MarketInfo(_Symbol,MODE_STOPLEVEL), MarketInfo(_Symbol,MODE_FREEZELEVEL))*_Point;
Membre depuis Jun 04, 2015
posts 29
Sep 15, 2015 at 10:01
Here we go, all orders with magic xxx are modified - similar tp.
void PairLossModify(){
bool modifypairloss;
for(cnt=OrdersTotal();cnt>=0;cnt--){
if(OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES))
if(OrderSymbol()==Symbol() && OrderMagicNumber()==Magic){
if(OrderType()==OP_BUY){
if(OrderStopLoss()==0 && MaxPairLoss!=0){
RefreshRates();
modifypairloss=OrderModify(OrderTicket(),OrderOpenPrice(),NormalizeDouble(Ask+MaxPairLoss*pt,Digits),OrderTakeProfit(),0,Red);
}
}
if(OrderType()==OP_SELL){
if(OrderStopLoss()==0 && MaxPairLoss!=0){
RefreshRates();
modifypairloss=OrderModify(OrderTicket(),OrderOpenPrice(),NormalizeDouble(Bid-MaxPairLoss*pt,Digits),OrderTakeProfit(),0,Red);
}
}
}
}
}
void PairLossModify(){
bool modifypairloss;
for(cnt=OrdersTotal();cnt>=0;cnt--){
if(OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES))
if(OrderSymbol()==Symbol() && OrderMagicNumber()==Magic){
if(OrderType()==OP_BUY){
if(OrderStopLoss()==0 && MaxPairLoss!=0){
RefreshRates();
modifypairloss=OrderModify(OrderTicket(),OrderOpenPrice(),NormalizeDouble(Ask+MaxPairLoss*pt,Digits),OrderTakeProfit(),0,Red);
}
}
if(OrderType()==OP_SELL){
if(OrderStopLoss()==0 && MaxPairLoss!=0){
RefreshRates();
modifypairloss=OrderModify(OrderTicket(),OrderOpenPrice(),NormalizeDouble(Bid-MaxPairLoss*pt,Digits),OrderTakeProfit(),0,Red);
}
}
}
}
}
forex_trader_25447
Membre depuis Dec 21, 2010
posts 127
Sep 15, 2015 at 13:24
As I understand , You have 2 different MAGIC for BUY and SELL.
So the lines :
if(OrderSymbol()==Symbol() && OrderMagicNumber()==Magic)
{ if(OrderType()==OP_BUY) { /*Your code*/ }
if(OrderType()==OP_SELL) { /*Your code*/ }
}
Must be like this :
if(OrderSymbol()==Symbol())
{ if(OrderType()==OP_BUY && OrderMagicNumber()==MagicBUY) { /*Your code*/ }
if(OrderType()==OP_SELL && OrderMagicNumber()==MagicSELL) { /*Your code*/ }
}
So the lines :
if(OrderSymbol()==Symbol() && OrderMagicNumber()==Magic)
{ if(OrderType()==OP_BUY) { /*Your code*/ }
if(OrderType()==OP_SELL) { /*Your code*/ }
}
Must be like this :
if(OrderSymbol()==Symbol())
{ if(OrderType()==OP_BUY && OrderMagicNumber()==MagicBUY) { /*Your code*/ }
if(OrderType()==OP_SELL && OrderMagicNumber()==MagicSELL) { /*Your code*/ }
}
*Lutilisation commerciale et le spam ne seront pas tolérés et peuvent entraîner la fermeture du compte.
Conseil : Poster une image/une url YouTube sera automatiquement intégrée dans votre message!
Conseil : Tapez le signe @ pour compléter automatiquement un nom dutilisateur participant à cette discussion.
